CC-1188: add crystal dependency resolution #192
Conversation
|
After a lot of searching, added this library to the list of dependencies. |
dockerfiles/crystal-1.12.Dockerfile
Outdated
| RUN mkdir -p /app-cached/ | ||
| RUN if [ -d "/app/lib" ]; then mv /app/lib /app-cached/lib; fi | ||
|
|
||
| RUN echo "cd \${CODECRAFTERS_SUBMISSION_DIR} && crystal build -p -s -t -o server app/main.cr && sed -i '/^crystal/ s/^/# /' ./spawn_redis_server.sh" > /codecrafters-precompile.sh |
There was a problem hiding this comment.
Not pertinent to this PR, but just wanted to note: looks like this pattern is becoming commonplace in a lot of our languages. Need to find a better solution. This commenting stuff feels wonky - if a user edits the file it isn't going to be clear to them that there's a hidden script that relies on the file's structure.
| @@ -0,0 +1,2 @@ | |||
| lib/ | |||
| server No newline at end of file | |||
There was a problem hiding this comment.
Binaries typically get placed in bin/ or so for most languages - what's the default that Crystal uses?
There was a problem hiding this comment.
lib/ is where the dependencies are stored.
And server is the final artifact. (We are passing this name with the -o flag).
There was a problem hiding this comment.
No other build artifacts would be there in the /app dir.
|
@ryan-gang let's spend some time today thinking about how we can avoid the precompile commenting situation, and how we can make this more transparent to the user (not related to this PR per-se, just a general note) |
|
Gonna keep this on hold for a bit - will revisit soon |
2 participants
No description provided.