Skip to content

Fix: flush() now calls libftdi(>= 1.5) tc[io]flush functions. #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

syha6821
Copy link

flush() now calls libftdi >= 1.5 tc[io]flush functions.
Closes #13

@codedstructure
Copy link
Owner

Thanks for this PR - looks useful and I appreciate that you've kept the code similar to the existing code.

One request though - as implemented the tests (e.g. make test) will typically fail. I also wonder if it should attempt the newer functions first (or even only?) since libftdi1.5 has been out a long time now.

@syha6821
Copy link
Author

I’ve amended the previous commit.
I’ve included the test code as well, and since the flush-related implementation in versions earlier than 1.5 contains bugs, it makes sense to support only version 1.5 and above, so I omitted the 1.4 code.

@syha6821 syha6821 changed the title Fix: flush() now calls libftdi >= 1.5 tc[io]flush functions. Fix: flush() now calls libftdi(>= 1.5) tc[io]flush functions. Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flush now uses ftdi_tcioflush() when libftdi ≥ 1.5.
2 participants