Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCAP-138: Added OneDrive transfer support. #4

Merged
merged 15 commits into from
Jun 17, 2024
Merged

Conversation

jamesiarmes
Copy link
Member

@jamesiarmes jamesiarmes commented Jun 6, 2024

🔗 Jira ticket

CCAP-138

✍️ Description

Added /transfer endpoint with support for a url source and OneDrive destination.

📷 Design reference

Tech Spec

🧪 Testing instructions

  • Checkout the code and run bundle install to install dependencies

  • Set the ONEDRIVE_CLIENT_ID, ONEDRIVE_CLIENT_SECRET, ONEDRIVE_TENANT_ID, and ONEDRIVE_DRIVE_ID environment variables using the values in LastPass

  • Run bundle exec rackup (or docker compose up) to start the API

  • Run the following to transfer a document to onedrive

    curl -H 'Content-Type: application/json' \
    -d '{ "source": { "type": "url", "url": "https://file-examples.com/storage/fe83e1f11c664c2259506f1/2017/10/file-example_PDF_500_kB.pdf" }, "destination": { "type": "onedrive", "path": "pr/review", "filename": "review-test.pdf" } }' \
    -X POST \
    http://localhost:9292/transfer

✅ Completion tasks

  • Added relevant tests
  • Meets acceptance criteria

Copy link

github-actions bot commented Jun 6, 2024

🔍 Vulnerabilities of pr-4:latest

📦 Image Reference pr-4:latest
digestsha256:bca67a8d98c66cf3b21817dd84c39567aecdf7d781756dbbed0e376b3c0c5d3f
vulnerabilitiescritical: 0 high: 0 medium: 0 low: 0
size483 MB
packages706
📦 Base Image ruby:3
also known as
  • 3-bookworm
  • 3.3
  • 3.3-bookworm
  • 3.3.3
  • 3.3.3-bookworm
  • bookworm
  • latest
digestsha256:e53115d6d220b102a662bc95ce16da5b03d7de9817d383681b0057cf023a3de6
vulnerabilitiescritical: 1 high: 2 medium: 3 low: 103 unspecified: 3

@jamesiarmes jamesiarmes marked this pull request as ready for review June 7, 2024 15:43
doc/destination.md Outdated Show resolved Hide resolved
doc/destination.md Outdated Show resolved Hide resolved
doc/destination.md Outdated Show resolved Hide resolved
doc/destination.md Outdated Show resolved Hide resolved
@cy-by
Copy link

cy-by commented Jun 17, 2024

@jamesiarmes rec:

new file called sample.env with:

export ONEDRIVE_CLIENT_ID=
export ONEDRIVE_CLIENT_SECRET=
export ONEDRIVE_TENANT_ID=
export ONEDRIVE_DRIVE_ID=

Copy link

@cy-by cy-by left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired on my concerns with James, approved!

Copy link

@cy-by cy-by left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jamesiarmes jamesiarmes merged commit 06b4c4f into main Jun 17, 2024
7 checks passed
@jamesiarmes jamesiarmes deleted the ccap-138-onedrive branch June 17, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants