Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Revamp the session interceptor to work when submission is unset. #557

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

bseeger
Copy link
Contributor

@bseeger bseeger commented May 23, 2024

When a session is not null, but does not have a submission id, an error is thrown. This adjusts the session interceptor to successfully catch that scenario and work through it.

This also adds a url parameter to help indicate that a redirect has happened. Then the app can catch that and do something if it wants. Ideally the redirect url could be a configurable parameter, but it doesn't seem like the
interceptor can read the configuration. Must do more testing here.

Issue tracking number 🔗

Description of change ✍️

Priority 🥇

Effect on other applications using FFB 🌊

Testing

✅ Checklist before requesting a review

  • Does the new code follow our preferred coding
    style
    ?
  • Does the code include javadocs, where necessary?
  • Have tests for this feature been added / updated?
  • Has the readme been updated?

@bseeger bseeger marked this pull request as draft May 23, 2024 14:23
@bseeger bseeger changed the title Revamp the session interceptor to work when submission is unset. WIP: Revamp the session interceptor to work when submission is unset. May 23, 2024
@bseeger bseeger force-pushed the update_session_interceptor branch from 544c196 to 903e50b Compare June 3, 2024 13:53
When a session is not null, but does not have a submission id, an error
is thrown.  This adjusts the session interceptor to successfully catch
that scenario and work through it.
@bseeger bseeger force-pushed the update_session_interceptor branch from 903e50b to 9b0744e Compare June 3, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants