Fixes #415 - adds vanity number #683
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #415 - adds vanity number to phone partial and test spec.
anselmbradford
force-pushed
the
415-vanity-phone-number
branch
from
192b0e8
to
f7a5a80
Compare
|
Looks like: Location details: Search results view: |
|
@monfresh Ready for merge. Thx! |
|
Looks good to me. I'll update the vanity number in the sample data to add a dash after 703 so that it looks like 703-555-ABCD, which is how it's most likely to be entered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #415 - adds vanity number to phone partial and test spec.