Fyst 663 implement form 502 su xml pdf part 1 #4942
Conversation
|
Heroku app: https://gyr-review-app-4942-a9d00e5c3015.herokuapp.com/ |
| def initialize(value_access_tracker:, lines:, intake:) | ||
| @value_access_tracker = value_access_tracker | ||
| @lines = lines | ||
| @intake = intake |
There was a problem hiding this comment.
[pebble] aside from the assignment on line 10, the intake isn't referenced so i don't believe we need to allocate an instance variable for it.
There was a problem hiding this comment.
ah, this is what happens when you're new and copy pasta what you've seen in other files, you're completely right. there's no need to allocate an instance variable.
app/lib/pdf_filler/md502_su_pdf.rb
Outdated
| def initialize(submission) | ||
| @submission = submission | ||
| builder = StateFile::StateInformationService.submission_builder_class(:md) | ||
| @xml_document = builder.new(submission).document |
There was a problem hiding this comment.
[pebble] similar to previous comment -- doesn't look like this instance variable is referenced anywhere in this class. could it be removed?
| def document | ||
| build_xml_doc("Form502SU", documentId: "Form502SU") do |xml| | ||
| xml.Subtractions do |subtractions| | ||
| subtractions.Total calculated_fields.fetch(:MD502_SU_LINE_1) |
There was a problem hiding this comment.
[pebble] is there supposed to be an = here or is Total a method name receiving a parameter?
There was a problem hiding this comment.
this is intentional! the build_xml_doc method generates the xml for the state return. therefore the value for Total will be assigned from this method.
…form 502SU, and add code letters from form 502SU to form 502
# Conflicts: # app/lib/efile/line_data.yml # app/lib/efile/md/md502_calculator.rb # spec/lib/efile/md/md502_calculator_spec.rb # spec/lib/pdf_filler/md502_pdf_spec.rb
Co-authored-by: Mike Rotondo <[email protected]>
app/lib/pdf_filler/md502_pdf.rb
Outdated
| @@ -85,5 +90,21 @@ def filing_status(method) | |||
| def checkbox_value(value) | |||
| value.present? ? 'Yes' : 'Off' | |||
| end | |||
|
|
|||
| def generate_codes_for_502_su | |||
| calculated_fields_code_letters = {MD502_SU_LINE_AB: "ab", MD502_SU_LINE_U: "u", MD502_SU_LINE_V: "v"} | |||
There was a problem hiding this comment.
[specs of dust] I think this would be slightly better with newlines for each pair (esp because the list may grow in the future), but incredibly minor.
| calculated_fields_code_letters = {MD502_SU_LINE_AB: "ab", MD502_SU_LINE_U: "u", MD502_SU_LINE_V: "v"} | |
| calculated_fields_code_letters = { | |
| MD502_SU_LINE_AB: "ab", | |
| MD502_SU_LINE_U: "u", | |
| MD502_SU_LINE_V: "v" | |
| } |
There was a problem hiding this comment.
happy to do that :)
Co-authored-by: Mike Rotondo <[email protected]>
Co-authored-by: Mike Rotondo <[email protected]>
Link to pivotal/JIRA issue
https://codeforamerica.atlassian.net/browse/FYST-663
Is PM acceptance required? (delete one)
What was done?
This PR adds Form 502SU including personal information, lines 1, and ab. It also adds the subtractions total from line 1 in Form 502 SU to Form 502.
How to test?
Line ab includes information from DF JSON interestOnGovernmentBonds, so an interest report including the interestOnGovernmentBonds is needed.
Screenshots (for visual changes)