Fyst 996 add two income sub md

[squanto]

Link to pivotal/JIRA issue

https://codeforamerica.atlassian.net/browse/FYST-996

Is PM acceptance required? (delete one)

• Yes - don't merge until JIRA issue is accepted!

What was done?

• add a two income subtractions form to maryland intakes
• add columns to capture primary and spouse deduction amounts

How to test?

• go through the maryland flow for creating an intake
• when selecting a payload to import, select one with a fed student loan amount, like "zeuse many w2's"
• Verify
• Risk Assessment
• n/a

Screenshots (for visual changes)

[github-actions]

Heroku app: https://gyr-review-app-4945-f3f4db820050.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4945 (optionally add --tail)

[arinchoi03]

can we add some feature spec expectations in the spec/features/state_file/complete_intake_spec.rb for the MD context?
happy to chat through the comments as well.

Also if you end up changing the migration, you may have to close & reopen the PR to re-create the heroku env with the migration from scratch!

[arinchoi03]

It says Updated: Page displays right before ID page in the Jira ticket, has this been updated to move before the UnemploymentController? Maybe we can ask if this comes before or after the unemployment controller?

[squanto]

ah yes, just double checked with the ticket author Erica and this should go after the unemployment controller, updated 👍

[arinchoi03]

can we call this primary_student_loan_interest_ded_amount
also spouse_student_loan_interest_ded_amount (remove _cents for both)

can we also make this a decimal column like all our other _amount or _amt fields?

ex:

    add_column :state_file_az_intakes, :charitable_cash_amount, :decimal, precision: 12, scale: 2

[squanto]

updated this column, and added a feature spec context for mfj to include this added two income sub form 👍

[squanto]

note - seeing a few failing specs on circleci that pass locally (run)

  1) StateFile::MdPermanentAddressForm#save they say yes (mailing address is confirmed as permanent address) saves imported_permanent_address_confirmed as true
     Failure/Error: expect(intake.confirmed_permanent_address).to eq "yes"
     
       expected: "yes"
            got: 0
     
       (compared using ==)
     # ./spec/forms/state_file/md_permanent_address_form_spec.rb:195:in `block (4 levels) in <main>'
     # ./spec/support/locale.rb:4:in `block (2 levels) in <main>'

  2) StateFile::MdPermanentAddressForm#save they say yes (mailing address is confirmed as permanent address) intake already has permanent address fields saved overwrites with address fields from 1040
     Failure/Error: expect(intake.confirmed_permanent_address).to eq "yes"
     
       expected: "yes"
            got: 0
     
       (compared using ==)
     # ./spec/forms/state_file/md_permanent_address_form_spec.rb:214:in `block (5 levels) in <main>'
     # ./spec/support/locale.rb:4:in `block (2 levels) in <main>'

  3) StateFile::MdPermanentAddressForm#save they say no (mailing address not the same as permanent address) saves imported_permanent_address_confirmed as true
     Failure/Error: expect(intake.confirmed_permanent_address).to eq "no"
     
       expected: "no"
            got: 0
     
       (compared using ==)
     # ./spec/forms/state_file/md_permanent_address_form_spec.rb:243:in `block (4 levels) in <main>'
     # ./spec/support/locale.rb:4:in `block (2 levels) in <main>'

Finished in 1.09 seconds (files took 6.72 seconds to load)
3 examples, 3 failures

Failed examples:

rspec ./spec/forms/state_file/md_permanent_address_form_spec.rb:191 # StateFile::MdPermanentAddressForm#save they say yes (mailing address is confirmed as permanent address) saves imported_permanent_address_confirmed as true
rspec ./spec/forms/state_file/md_permanent_address_form_spec.rb:210 # StateFile::MdPermanentAddressForm#save they say yes (mailing address is confirmed as permanent address) intake already has permanent address fields saved overwrites with address fields from 1040
rspec ./spec/forms/state_file/md_permanent_address_form_spec.rb:238 # StateFile::MdPermanentAddressForm#save they say no (mailing address not the same as permanent address) saves imported_permanent_address_confirmed as true


3 examples, 3 failures

Took 10 seconds
Tests Failed

rerunning

[arinchoi03]

a few more comments but I swear we're nearly there! up to pair on these too if you want :)

[arinchoi03]

Hmm I see a potential problem here:

primary: 20.75 + spouse: 20.75 = total loan interest: 41.50
use .to_i for each value:
20 + 20 = 41

therefore the sum will never be equal. I guess fed_student_loan_interest is always an integer (according to the xsd) so maybe we'll never be in this situation?

I think we should sum the value without converting to_i, then convert to an integer (preferably round?) and make sure they're equal? what do you think?

(primary_student_loan_interest_ded_amount + spouse_student_loan_interest_ded_amount).round != @intake.direct_file_data.fed_student_loan_interest

[arinchoi03]

also could we add a spec for this validation?

[arinchoi03]

is it possible to use Transfer Zeus two w2s for the fixture in the existing spec?

[arinchoi03]

hmm why did we need to update this in this PR?

[arinchoi03]

oh is it b/c of this? #4945 (comment) that's so odd. Did you double check running these specs locally on main branch?