Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nj 107 - question for estimated tax payments line 57 and shared money test #4951

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

nj 107 - question for estimated tax payments line 57 and shared money test #4951

wants to merge 4 commits into from

Conversation

aloverso
Copy link
Contributor

@aloverso aloverso commented Nov 7, 2024 •
edited
Loading

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

What was done?

  • Question for estimated tax payments, include in review and PDF and XML
  • Shared money test refactor for all money fields

How to test?

  • use minimal DF
  • test both including a value, and that you can move past the screen without providing a value

Screenshots (for visual changes)

image
image
image
image

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Heroku app: https://gyr-review-app-4951-bb0bbd60ec8a.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4951 (optionally add --tail)

arinchoi03
arinchoi03 approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@arinchoi03 arinchoi03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ looks good to me!

spec/support/shared_examples/nj_money_field.rb Show resolved Hide resolved
app/views/state_file/questions/nj_estimated_tax_payments/edit.html.erb
:estimated_tax_payments,
t('.label'),
classes: ["form-width--long"],
options: { placeholder: "0" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[q] the placeholder default is 0.00, is this a design choice on NJ team to use 0 instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, Hannah could speak to that further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arinchoi03 arinchoi03 arinchoi03 approved these changes

@mluedke2 mluedke2 mluedke2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aloverso @mluedke2 @arinchoi03