Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYST-509 Add Federal Taxable Income interest information to NC400 Schedule S xml and pdf #4955

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

arinchoi03
Copy link
Contributor

@arinchoi03 arinchoi03 commented Nov 7, 2024

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Utilized the existing fed_taxable_income attr reader to set the value on NC400 Schedule S line 18 ("USInterestInc")
  • I also removed the instructions page of the NC400-TY2024.pdf AND ncD400-Schedule-S-TY2024.pdf

How to test?

  • Describe the testing approach taken to verify the changes, including:
    • Unit/manual tests
    • Test data used: Laney QSS is the only one that has fed_taxable_income but you can also edit this value for other fixtures if desired.
  • Specify any relevant testing environments used: development/please use heroku for acceptance

Screenshots (for visual changes)

Screenshot 2024-11-07 at 3 24 18 PM Screenshot 2024-11-07 at 3 24 35 PM

Copy link

github-actions bot commented Nov 7, 2024

Heroku app: https://gyr-review-app-4955-b7a43a589a90.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4955 (optionally add --tail)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants