refactor: clean up parentheses on assign and ternary

codeigniter4 · Oct 30, 2024 · 3f8feaa · 3f8feaa
1 parent dede747
commit 3f8feaa
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/system/Database/BaseConnection.php b/system/Database/BaseConnection.php
@@ -848,7 +848,7 @@ public function transBegin(bool $testMode = false): bool
         // Reset the transaction failure flag.
         // If the $test_mode flag is set to TRUE transactions will be rolled back
         // even if the queries produce a successful result.
-        $this->transFailure = ($testMode);
+        $this->transFailure = $testMode;
 
         if ($this->_transBegin()) {
             $this->transDepth++;

diff --git a/system/Database/MySQLi/Connection.php b/system/Database/MySQLi/Connection.php
@@ -96,7 +96,7 @@ public function connect(bool $persistent = false)
             $port     = null;
             $socket   = $this->hostname;
         } else {
-            $hostname = ($persistent) ? 'p:' . $this->hostname : $this->hostname;
+            $hostname = $persistent ? 'p:' . $this->hostname : $this->hostname;
             $port     = empty($this->port) ? null : $this->port;
             $socket   = '';
         }

diff --git a/system/Helpers/form_helper.php b/system/Helpers/form_helper.php
@@ -582,7 +582,7 @@ function set_select(string $field, string $value = '', bool $default = false): s
         }
 
         if ($input === null) {
-            return ($default) ? ' selected="selected"' : '';
+            return $default ? ' selected="selected"' : '';
         }
 
         if (is_array($input)) {
@@ -636,7 +636,7 @@ function set_checkbox(string $field, string $value = '', bool $default = false):
             return ($input === $value) ? ' checked="checked"' : '';
         }
 
-        return ($default) ? ' checked="checked"' : '';
+        return $default ? ' checked="checked"' : '';
     }
 }
 
@@ -673,7 +673,7 @@ function set_radio(string $field, string $value = '', bool $default = false): st
             return ((string) $input === $value) ? ' checked="checked"' : '';
         }
 
-        return ($default) ? ' checked="checked"' : '';
+        return $default ? ' checked="checked"' : '';
     }
 }
 

diff --git a/system/Pager/Pager.php b/system/Pager/Pager.php
@@ -288,7 +288,7 @@ public function getPageURI(?int $page = null, string $group = 'default', bool $r
             $uri->setQueryArray($query);
         }
 
-        return ($returnObject)
+        return $returnObject
             ? $uri
             : URI::createURIString(
                 $uri->getScheme(),