Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add file permission check workflow #8922

Merged
merged 1 commit into from
May 30, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 30, 2024

Description
See #8918 (review)

Result:

Run php utils/check_permission_x.php

Files with unnecessary execution permissions were detected:
- admin/starter/tests/index.html
- admin/starter/tests/.htaccess
- app/Config/DocTypes.php
- system/Test/Mock/MockResponse.php
- system/Helpers/text_helper.php
- system/Helpers/cookie_helper.php
- system/Helpers/inflector_helper.php
- system/Helpers/html_helper.php
- system/HTTP/IncomingRequest.php
- system/Database/SQLSRV/Builder.php
- system/Database/SQLSRV/Connection.php
- system/Database/SQLSRV/PreparedQuery.php
- system/Database/SQLSRV/Forge.php
- system/Database/SQLSRV/Result.php
- system/Database/SQLSRV/Utils.php
- tests/system/Helpers/InflectorHelperTest.php
- tests/system/Helpers/HTMLHelperTest.php
- tests/system/Helpers/NumberHelperTest.php
- tests/system/Helpers/CookieHelperTest.php
- tests/system/Helpers/TextHelperTest.php
- user_guide_src/source/helpers/inflector_helper.rst
- user_guide_src/source/helpers/html_helper.rst
- user_guide_src/source/helpers/text_helper.rst
- user_guide_src/source/helpers/cookie_helper.rst
- user_guide_src/source/database/query_builder.rst
- user_guide_src/source/general/common_functions.rst
- writable/logs/index.html
- writable/index.html
- writable/debugbar/index.html
- writable/cache/index.html
- writable/.htaccess
- writable/uploads/index.html
- writable/session/index.html
Error: Process completed with exit code 1.

https://github.com/codeigniter4/CodeIgniter4/actions/runs/9296154395/job/25584234302?pr=8922

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • [] Conforms to style guide

@kenjis kenjis added the github_actions Pull requests that update Github_actions code label May 30, 2024
@kenjis kenjis force-pushed the add-permission-check branch 2 times, most recently from 4796283 to ca9a5a0 Compare May 30, 2024 02:53
@ddevsr ddevsr requested a review from paulbalandan May 30, 2024 03:08
@kenjis kenjis merged commit dcbcf38 into codeigniter4:develop May 30, 2024
11 checks passed
@kenjis kenjis deleted the add-permission-check branch May 30, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants