Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect complex language strings when using validation #9201

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

michalsn
Copy link
Member

Description
This PR fixes a bug where complex language strings in the validation class are not handled properly.

The problem was that in the validation class, we were forming the final message using the str_replace() function, instead of using the built-in solutions that MessageFormatter::formatMessage gives us.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added the bug Verified issues on the current code behavior or pull requests that will fix them label Sep 25, 2024
@dgvirtual
Copy link
Contributor

I tried it and it seems to work fine. Thanks @michalsn

@michalsn
Copy link
Member Author

@dgvirtual Ok, thank you for testing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Language strings with plural forms do not work in within validations
2 participants