Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable rector code quality level 14 #9232

Conversation

samsonasik
Copy link
Member

Description

Apply SimplifyDeMorganBinaryRector for Simplify negated conditions with de Morgan theorem

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

Ready to merge 👍

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@samsonasik
Copy link
Member Author

samsonasik commented Oct 21, 2024

Thank you @MGatner @paulbalandan for the review, let's merge ;)

@samsonasik samsonasik merged commit ba62eae into codeigniter4:develop Oct 21, 2024
41 checks passed
@samsonasik samsonasik deleted the refactor-enable-rector-code-quality-level-14 branch October 21, 2024 00:52
@kenjis kenjis added the refactor Pull requests that refactor code label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants