-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: Improve call as service()
#9248
perf: Improve call as service()
#9248
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Although using the Service
class was nice from an IDE perspective - easy access to the method source. But performance is more important.
Someday there will be a person who will create an IDE extension for CI 4. And we will improve the experience |
f322c1c
to
ed9a1d3
Compare
👋 Hi, @neznaika0! |
e7b9d12
to
ac0b7db
Compare
this needs rebase once more :) |
ac0b7db
to
ea38947
Compare
Thank you @neznaika0 |
Description
Replace the use of
Services::some()
withservice('some')
. In theory, for large queries (> 100,000), the difference in execution will be noticeable.#8607 #8623
All texts are executed, there should be no problems.
I left it unchanged tests/system/Config/ServicesTest.php
The examples in the documentation have not been changed.
It is not possible to call
Services::createRequest()
as aservice ('createRequest
)', rector says:Checklist: