-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Fix phpstan codeigniter.frameworkExceptionInstance #9389
base: develop
Are you sure you want to change the base?
refactor: Fix phpstan codeigniter.frameworkExceptionInstance #9389
Conversation
Can you tell me why my GA is crashing? It's a copy of this repository. |
you probably need to mirror your fork repo with this repo tag as well, as it seems you don't have any tag at https://github.com/neznaika0/codeigniter-dev/tags , if the PR is green, i think it is fine just as is, as it may related with branch alias Lines 82 to 87 in 42a00ff
/cc @paulbalandan |
I added all tags and master branch. It didn't help |
My best guess is that I think this can be "fixed" by not running the GA in the forks. |
07205a1
to
34a41d3
Compare
There seems to be a mistake in applying the rules comment_to_phpdoc |
If you have time, pls send a PR to the coding-standard repo adding |
But before that, he ignores |
I looked at the code of comment_to_phpdoc. If there's a variable assignment it treats it as a structural element so it changes the comment to a phpdoc. |
Rewrite as phpDoc? |
Yes. This is what it looks like: This is correct because the -// @var int $foo
+/** @var int $foo */
$foo = some_function(); Continuing from that, if the comment is the last in the line, it will be considered for the next line. So, the fixer thinks the comment is for the assignment to |
34a41d3
to
df17203
Compare
Description
Invoking an
FrameworkException
using the method onlyChecklist: