Skip to content

Conversation

@Chucho-Kun
Copy link

@Chucho-Kun Chucho-Kun commented Nov 19, 2025

Description
PHPStan errors were eliminated by reducing the baseline to 1200 errors as part of my contribution to the good first issue label
The modifications is in the branch fix/issue-8732-basemodel-types and were validated with the following command

composer phpstan:check -- --memory-limit=512M

@mergeable
Copy link

mergeable bot commented Nov 19, 2025

Hi there, Chucho-Kun! 👋

Thank you for sending this PR!

We expect the following in all Pull Requests (PRs).

Important

We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.

If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work
on the framework than you do. Please make it as painless for your contributions to be included as possible.

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md

Sincerely, the mergeable bot 🤖

@Chucho-Kun Chucho-Kun changed the title Fix PHPStan iterable type errors in BaseModel, CLI, LocalizationFinder, AutoRouteCollector and Modules Fix PHPStan iterable type errors in BaseModel, CLI, LocalizationFinder, AutoRouteCollector and Modules #8732 Nov 19, 2025
@Chucho-Kun Chucho-Kun changed the title Fix PHPStan iterable type errors in BaseModel, CLI, LocalizationFinder, AutoRouteCollector and Modules #8732 fix(core): resolve PHPStan iterable type errors (#8732) Nov 19, 2025
@michalsn
Copy link
Member

Thank you. Please omit any modifications related to Kint, since it was already updated in #9802.

@Chucho-Kun Chucho-Kun closed this Nov 19, 2025
@Chucho-Kun Chucho-Kun reopened this Nov 19, 2025
@Chucho-Kun Chucho-Kun force-pushed the fix/issue-8732-basemodel-types branch from 07b45af to e887557 Compare November 19, 2025 23:28
@neznaika0
Copy link
Contributor

For the BasicModel, I recently closed PR. We could not agree on the rules of phpDoc - phpstan or simple types.

I stopped correcting the typing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants