Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all repo to contribute page #364

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

datamweb
Copy link

Demo:

Screenshot 2023-03-30 175806

app/Views/contribute.php Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Mar 31, 2023

Pull Request Test Coverage Report for Build 4576810717

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.86%

Totals Coverage Status
Change from base Build 4404817660: 0.0%
Covered Lines: 243
Relevant Lines: 329

💛 - Coveralls


<?= $this->endSection() ?>
<?= $this->endSection() ?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add LF at the end of the file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to be fixed.

app/Config/GitHub.php Outdated Show resolved Hide resolved
@datamweb datamweb force-pushed the add-all-repo-to-contribute branch from 2f1edba to 36b8893 Compare March 31, 2023 15:04
@datamweb datamweb force-pushed the add-all-repo-to-contribute branch from d349cc2 to 55686e7 Compare March 31, 2023 15:38
@datamweb datamweb requested a review from kenjis March 31, 2023 15:49
@MGatner
Copy link
Collaborator

MGatner commented Apr 1, 2023

I like the idea but it could be pretty busy. I wonder if these should go on a dedicated page, and keep the main contribution page as it is? Or maybe even better, have a summary of contributors across all the repos - like a sum of all contributions.

@kenjis
Copy link
Contributor

kenjis commented Apr 1, 2023

Screenshot 2023-04-01 21 12 24

@datamweb datamweb marked this pull request as draft April 1, 2023 14:39
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4565047629

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.86%

Totals Coverage Status
Change from base Build 4404817660: 0.0%
Covered Lines: 243
Relevant Lines: 329

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4565047629

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.86%

Totals Coverage Status
Change from base Build 4404817660: 0.0%
Covered Lines: 243
Relevant Lines: 329

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants