Skip to content

feat: use cobra library instead of flag #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2024
Merged

feat: use cobra library instead of flag #10

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f9cb37
deps: add library `cobra v1.8.1` to manage CLI
d3cryptofc Sep 25, 2024
fbf16c1
imp(main): using `cobra` library instead of `flag`
d3cryptofc Sep 25, 2024
fa13084
fix(cli): inverted boolean flag `--no-sound`
d3cryptofc Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions cmd/hyprnotify/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,24 @@
package main

import (
"flag"
"github.com/codelif/hyprnotify/internal"
"github.com/spf13/cobra"
)

func main() {
var enableSound bool
const message = "Disable sound"

flag.BoolVar(&enableSound, "no-sound", false, message)
flag.BoolVar(&enableSound, "silent", false, message)
flag.BoolVar(&enableSound, "s", false, message)
Cmd := &cobra.Command{
Use: "hyprnotify",
Long: `DBus Implementation of Freedesktop Notification spec for 'hyprctl notify'`,
Run: func(cmd *cobra.Command, args []string) {
internal.InitDBus(enableSound)
},
}

flag.Parse()
CmdFlags := Cmd.Flags()

internal.InitDBus(enableSound)
CmdFlags.BoolVarP(&enableSound, "no-sound", "s", false, "disable sound, silent mode")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this reverses the enableSound condition, so setting the --no-sound flag actually enables sound and vice versa

Copy link
Contributor Author

@d3cryptofc d3cryptofc Sep 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied the original, how strange is that..

https://github.com/codelif/hyprnotify/blob/main/cmd/hyprnotify/main.go#L12-L14

and I thought there was no sound due to some lack of dependence 🤔

Edit 2:

It seems that in version 7.0 it was correct:

https://github.com/codelif/hyprnotify/blob/v0.7.0/cmd/hyprnotify/main.go#L9-L16

But in the future it was reversed in this commit:

2c34d12

I will make the correction commit.


Cmd.Execute()
}
Loading