ci: Add pre-commit workflow#3284
Closed
mdeweerd wants to merge 1 commit intocodespell-project:mainfrom
Closed
Conversation
Member
|
I think inline comments are neat but I'm worried about adding a bunch of new infrastructure that we need to maintain. Ideally contributors would |
Contributor
Author
|
Seeing the annotation in context is IMHO more efficient, not just neat. Annotations are fairly new - I think that we'll see more features coming in the github ui. I suppose that at some point in time an annotation can be turned into an issue in the UI - something that I do not expect in the textual report/details view. |
Contributor
Author
|
1 year old, so considered as "not accepted". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This runs the pre-commit setup in a github workflow that will also annotate the PRs.