Skip to content

ci: Add pre-commit workflow#3284

Closed
mdeweerd wants to merge 1 commit intocodespell-project:mainfrom
mdeweerd:workflow/pre-commit
Closed

ci: Add pre-commit workflow#3284
mdeweerd wants to merge 1 commit intocodespell-project:mainfrom
mdeweerd:workflow/pre-commit

Conversation

@mdeweerd
Copy link
Contributor

This runs the pre-commit setup in a github workflow that will also annotate the PRs.

@larsoner
Copy link
Member

I think inline comments are neat but I'm worried about adding a bunch of new infrastructure that we need to maintain. Ideally contributors would pre-commit install --install-hooks locally and see the errors. And if they don't do that, then click the "details" button on the failed CI.

@mdeweerd
Copy link
Contributor Author

Seeing the annotation in context is IMHO more efficient, not just neat.
If the annotations break in the future, the related steps can just be disabled/commented/removed.

Annotations are fairly new - I think that we'll see more features coming in the github ui. I suppose that at some point in time an annotation can be turned into an issue in the UI - something that I do not expect in the textual report/details view.

@mdeweerd
Copy link
Contributor Author

1 year old, so considered as "not accepted".

@mdeweerd mdeweerd closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants