Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent inline toolbar from closing in nested instance of editor #2780

Conversation

gorenburg
Copy link
Contributor

Based on #2581

Closes issue with inline toolbar being closed in the nested editor instance when clicking on the toolbar button with some actions. The fix is taken from #2581; this PR adds cypress tests for the fix

Copy link
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked fine, thanks. Please, add a line to the changelog under the 2.30.6 section

@neSpecc
Copy link
Member

neSpecc commented Aug 14, 2024

There is an ESLint error:

/home/runner/work/editor.js/editor.js/test/cypress/support/utils/nestedEditorInstance.ts
   1:1   error    All imports in the declaration are only used as types. Use `import type`  @typescript-eslint/consistent-type-imports

@gorenburg
Copy link
Contributor Author

There is an ESLint error:

/home/runner/work/editor.js/editor.js/test/cypress/support/utils/nestedEditorInstance.ts
   1:1   error    All imports in the declaration are only used as types. Use `import type`  @typescript-eslint/consistent-type-imports

was fixing it the same moment you added comment 😄

@gorenburg
Copy link
Contributor Author

Ready to ship? 😀

@neSpecc neSpecc merged commit b6ba44d into codex-team:next Sep 13, 2024
4 checks passed
@gorenburg gorenburg deleted the fix/prevent-inline-toolbar-from-closing-in-nested-instance branch September 20, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants