-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent inline toolbar from closing in nested instance of editor #2780
Merged
neSpecc
merged 6 commits into
codex-team:next
from
gorenburg:fix/prevent-inline-toolbar-from-closing-in-nested-instance
Sep 13, 2024
Merged
fix: prevent inline toolbar from closing in nested instance of editor #2780
neSpecc
merged 6 commits into
codex-team:next
from
gorenburg:fix/prevent-inline-toolbar-from-closing-in-nested-instance
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorenburg
requested review from
neSpecc,
gohabereg,
TatianaFomina and
ilyamore88
as code owners
July 17, 2024 14:40
neSpecc
approved these changes
Aug 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked fine, thanks. Please, add a line to the changelog under the 2.30.6 section
There is an ESLint error:
|
was fixing it the same moment you added comment 😄 |
Ready to ship? 😀 |
gorenburg
deleted the
fix/prevent-inline-toolbar-from-closing-in-nested-instance
branch
September 20, 2024 15:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2581
Closes issue with inline toolbar being closed in the nested editor instance when clicking on the toolbar button with some actions. The fix is taken from #2581; this PR adds cypress tests for the fix