feat(inline-toolbar): inline tools now can be used in the readonly mode #2832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
requested review from
gohabereg,
TatianaFomina and
ilyamore88
as code owners
gohabereg
approved these changes
Oct 2, 2024
| @@ -54,7 +55,7 @@ export default class InlineToolbar extends Module<InlineToolbarNodes> { | |||
| /** | |||
| * Currently visible tools instances | |||
| */ | |||
| private toolsInstances: Map<string, IInlineTool> | null = new Map(); | |||
| private tools: Map<InlineToolAdapter, IInlineTool> = new Map(); | |||
There was a problem hiding this comment.
we can't iterate over WeakMap
| return currentBlock.tool.inlineTools.size !== 0; | ||
| /** | ||
| * Inline toolbar will be shown only if the target is contenteditable | ||
| * In Read-Only mode, the target should be contenteditable with "false" value |
There was a problem hiding this comment.
Do we have this documented somewhere?
There was a problem hiding this comment.
not yet, it's the new behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline Toolbar now can be shown in read-only mode. Can be useful for tools like "Comments".
Inline Tools now can specify
isReadOnlySupportedstatic getter. If at least one such tool is available, the Inline Toolbar will be shown.