notifier and tooltip, fix closes #2591, #2390, #2462

[Sozialarchiv]

This fix moves the packages codex-notifier and codex-tooltip from devDependencies to dependencies.

Both packages are not only used as type imports:

editor.js/src/components/utils/notifier.ts

Line 7 in eb7ffcb

import notifier from 'codex-notifier';

editor.js/src/components/utils/tooltip.ts

Line 5 in eb7ffcb

import CodeXTooltips from 'codex-tooltip';

The patch fixes the following types errors:

node_modules/.pnpm/@[email protected]/node_modules/@editorjs/editorjs/types/api/notifier.d.ts:1:78 - error TS2307: Cannot find module 'codex-notifier' or its corresponding type declarations.

1 import {ConfirmNotifierOptions, NotifierOptions, PromptNotifierOptions} from 'codex-notifier';
                                                                               ~~~~~~~~~~~~~~~~

node_modules/.pnpm/@[email protected]/node_modules/@editorjs/editorjs/types/api/tooltip.d.ts:4:46 - error TS2307: Cannot find module 'codex-tooltip' or its corresponding type declarations.

4 import {TooltipContent, TooltipOptions} from 'codex-tooltip';

[Sozialarchiv]

@neSpecc Do I also have to modify the version number in pacakge.json?

[neSpecc]

please, update a changelog

[Sozialarchiv]

please, update a changelog

Done

[neSpecc]

@Sozialarchiv how are you reproducing such errors? I don't see it in my builds

[Sozialarchiv]

@Sozialarchiv how are you reproducing such errors? I don't see it in my builds

I couldn't reproduce the problem at first either. However, since it was mentioned in various issues, I looked into it a little.

You need a typescript project in which @editorjs/editorjs is a dependency. In addition, “skipLibCheck” in tsconfig.json must be true. Normally I have not activated this either, as it has no added value and costs performance. It is also false by default. However, there seem to be some users who have set the value to true.

[neSpecc]

I have skipLibCheck: true, but don't see that error.

[neSpecc]

Hey, @Sozialarchiv. Have you managed to reproduce these errors? Maybe you can provide a demo?

[Sozialarchiv]

Hey, @Sozialarchiv. Have you managed to reproduce these errors? Maybe you can provide a demo?

https://github.com/Sozialarchiv/editorjs-notifier-tooltip-error-demo

[neSpecc]

Thanks, @Sozialarchiv. Demo works fine with 2.31.0-rc.4