Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore (toolbox): improved shortcuts visibility when tool exports array of toolbox items #2846

Merged
merged 10 commits into from
Oct 16, 2024

Conversation

e11sy
Copy link
Contributor

@e11sy e11sy commented Oct 14, 2024

Problem

For now if tool exports array of toolbox items via

public static get toolbox(): ToolboxConfig {
    return [ 'array of toolbox items here' ]

we would see same shortcut for each of the toolbox items:
image

Solution

Now we would write shortcut only for first toolbox item of each tool
image

Changes

  • now toPopoverItem method of the toolbox forms secondaryLavel only for first toolbox item of each tool
  • added test for toolbox.cy.ts that checks new functionality
  • changed description of the tool-settings data property

@neSpecc neSpecc merged commit 3cd24c4 into next Oct 16, 2024
6 checks passed
@neSpecc neSpecc deleted the toobox-display-secondary-label branch October 16, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants