Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opacity and update Item-list #38

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

Daksh14
Copy link
Member

@Daksh14 Daksh14 commented May 5, 2020

This PR adds opacity classes and upgrades the item lists. Also updated documentation for both of them

@Daksh14 Daksh14 requested review from luap42 and ArtOfCode- and removed request for luap42 May 5, 2020 21:46
@Daksh14 Daksh14 added area: components Changes to design components area: documentation Improvements or additions to documentation area: utilities Changes to atomic utility classes/helpers labels May 5, 2020
@ArtOfCode- ArtOfCode- removed their request for review May 5, 2020 21:49
@ArtOfCode-
Copy link
Member

Deferring to @luap42 here.

@luap42
Copy link
Member

luap42 commented May 9, 2020

Looking at the docs preview:

preview of the changes of this PR

  • It's too large (was already said, just repeating here for completeness).
  • I think the effect on the "accepted answer" block is too heavy. I'd go with a lighter effect.
  • Don't use buttons just to show icons. Use utilities for creating visual effects, but buttons are for interactions.

@Daksh14
Copy link
Member Author

Daksh14 commented May 9, 2020

@mattjbrent and @cellio are currently working on the layout part and finalizing it. I'll have to wait and then replicate it.
Also for an accessibility reason, one could hover over them and know about the number of views, answers, etc. If that's possible with the utilities then I'll see

@cellio
Copy link
Member

cellio commented May 10, 2020

We don't want to grab ~35% of the horizontal space for stats widgets; that has a bad effect on the title.

We don't have the "accepted answer" concept, so we don't need to style that. (If we want this kind of highlighting for something else, we might want a less-assertive color.)

I like moving the votes over to the right, so the first thing you see is the title not the score. There's a proposal to do that on question pages too. @mattjbrent has some ideas about this for the question list; it's possible we won't even show a score number in the list. Maybe we want to abstract it away into vaguer "very positive - positive - meh - negative" scale. Alternatively (and my original proposal), we'd show +N/-M.

The gray last-modified text is very light; probably does not meet accessibility guidelines.

Support for tooltips on most page elements would be good for accessibility. (Also, any essential images should be backed by alt text for screen readers. But decorative graphics shouldn't as it just gets in the way for the user.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: components Changes to design components area: documentation Improvements or additions to documentation area: utilities Changes to atomic utility classes/helpers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants