Add post validations also to suggested edits (301, 764, 765) #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostValidations are defined now as the shared validations between posts and suggested edits. For checking the minimum body length, I switched it to checking the markdown body as that is a much better representation of the length. In my testing even a body with just "Hello" ended up being long enough after all the html that was added. I have altered the if statements on the validations for title and body length as those can be nil for suggested edits. This is not a problem, because other validations on Post already catch when they are empty. Additionally, the title and body were only extensively checked if the post type supported tags. I have now changed that such that title and body are always required for posts.
ArtOfCode-
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates out shared post validations to a concern and adds this concern on both Post and SuggestedEdit. This means that the validations will be in line between them. Some validations remain in Post as they are specific to posts (moderator_tags should not be checked on suggested edits, see #741).
I also fixed some (as far as I know) unreported issues with the validations not working as intended:
I have altered the if statements on the validations for title and body length as those can be nil for suggested edits (means no change suggested for them). This is not a problem for posts, because other validations on Post already catch when they are empty.
Fixes #301
Fixes #764
Fixes #765