Regex memoization #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tching immediately - memoization is used to prevent repeatedly recompiling the regex
hedyhli
reviewed
Sep 7, 2024
| else | ||
| { | ||
| reg = gc_flatmalloc(sizeof *reg); | ||
| const int status = regcomp(reg, reg_str, REG_EXTENDED | REG_NEWLINE); |
There was a problem hiding this comment.
Note that previously Regex also used the REG_NOSUB flag when compiling (Regex-match does not since it needs those subexpressions). I have no idea if it could affect the performance for Regex, though.
There was a problem hiding this comment.
Yeah I considered having different memoization buffers for the two functions but this felt easier - if the performance becomes concern I'll do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RegexandRegex-matchnow take two string parameters, performing the match immediately. Under the hood this uses memoization (using tables) to prevent the regex being recompiled.