-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow start delay option #294
Conversation
Extending the GRPC connection is not sufficient to get this working. You'll also need to define options for the method in the client and map them onto the connection at https://github.com/coinbase/temporal-ruby/blob/master/lib/temporal/client.rb#L43 |
Sounds good, I'll apply changes today, thanks @jeffschoner |
Hi @santiagodoldan! I'm doing some work right now that would also benefit from this feature. Let me know if you'd like a hand making the changes to get this PR over the line! |
I'll work on this during the weekend 💯 |
Hi santiagodoldan, I am very interested in this future for a PoC my company is conducting on temporal. Did you have a chance to get back to the PR or is there any way I could help on this ? Many thanks, |
98b7722
to
e82f24c
Compare
e82f24c
to
f41efb7
Compare
Sorry for the delay, I was super busy, thanks @jeffschoner for the help, I tested locally and it's working great, I was able to start workflows with different delays, here a screenshot of temporal dashboard |
@DeRauk can you take a look at this one? |
Can I get some feedback here? I'd love to get this one in |
Looking forward to seeing this feature merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me, but I don’t have merge permission. I’d suggest reaching out to DeRauk from Coinbase on Temporal Slack.
No description provided.