-
Notifications
You must be signed in to change notification settings - Fork 840
Feature/exact btc lightning #703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jllauwers
wants to merge
14
commits into
coinbase:main
Choose a base branch
from
jllauwers:feature/exact-btc-lightning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jllauwers2 <[email protected]>
🟡 Heimdall Review Status
|
|
@jllauwers is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a BTC Lightning implementation of the
exactscheme and exposes it through the demo site.TypeScript SDK (
typescript/packages/x402)exact/btc_lightningscheme with client + facilitator helpersschemes/exactentry pointDemo site (
site/)app/facilitator/lightning-lnd.tsLND_REST_URL,LND_MACAROON_HEX, andLIGHTNING_NETWORKenv varsexactscheme on BTC Lightning networks (e.g.btc-lightning-signet)/examples/lightningAPI route:X-PAYMENTheader: returns HTTP402with x402PaymentRequirementsfor BTC Lightning200with demo payload (message, network, transaction, sats, random number)/examples/lightning-demopage:/examples/lightningto fetch payment requirementsX-PAYMENTheader using the BTC LightningexactschemeDocs
site/README.mdto describe:exactscheme demo/examples/lightningand/examples/lightning-demoTests
Automated
pnpm testfrom/typescriptpnpm format && pnpm lintfrom/typescriptcd site && pnpm lintManual sanity tests
Facilitator / Lightning
LND_REST_URL,LND_MACAROON_HEX, andLIGHTNING_NETWORKinsite/.env.local/facilitatorendpoints and confirmed invalid inputs produce structured x402 errors (no500responses)/examples/lightningAPIGET /examples/lightningwithoutX-PAYMENT:402withx402Versionand at least oneaccepts[]entryaccepts[0].scheme === "exact"accepts[0].network === LIGHTNING_NETWORK(e.g.btc-lightning-signet)maxAmountRequiredmatches the expected sats amountGET /examples/lightningwith an invalid or unpaid BOLT11 invoice inX-PAYMENT:402with anerror/invalidReason/examples/lightning-demoUIcd site && pnpm dev/examples/lightning-demo:/examples/lightningresponseneedsPaymentstate200from/examples/lightningand saw the “Access granted” card showing:Checklist