fix(go): add settlement success check and skip settlement for error responses#722
Closed
madisoncarter1234 wants to merge 1 commit intocoinbase:mainfrom
Closed
Conversation
…esponses - Check settleResponse.Success before returning protected content - Skip settlement if handler returns 4xx/5xx status code - Update tests to expect correct behavior on settlement failure Matches TypeScript/Python middleware behavior.
🟡 Heimdall Review Status
|
|
@madisoncarter1234 is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
bump |
Contributor
|
Thanks a lot @madisoncarter1234, this has been fixed in v2 and the legacy packages are effectively frozen now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues in the Go gin middleware:
Missing settlement success check - Only checked for HTTP errors (
err != nil), notsettleResponse.Success. If facilitator returns 200 withsuccess: false, middleware would still return protected content.Missing response status check - Settled payments even when handler returned 4xx/5xx errors, charging users for failed requests.
Changes
settleResponse.Successcheck after settlementstatusCode >= 400check before calling settleTestPaymentMiddleware_SettlementFailsto expect 402 on settlement failureTestPaymentMiddleware_HandlerErrorSkipsSettlementtestRelated