fix(clients): remove invalid Access-Control-Expose-Headers request header #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ader The x402-fetch, x402-axios, and Python (httpx, requests) clients were setting Access-Control-Expose-Headers as a REQUEST header. This is incorrect - Access-Control-Expose-Headers is a RESPONSE header that only makes sense when set by the server, not the client. Setting this header in a request has no effect on CORS behavior. The server-side middlewares are responsible for setting this header in their responses to allow browser clients to access the X-PAYMENT-RESPONSE header.
|
@madisoncarter1234 is attempting to deploy a commit to the Coinbase Team on Vercel. A member of the Team first needs to authorize it. |
🟡 Heimdall Review Status
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Access-Control-Expose-Headersheader from client request headers in x402-fetch, x402-axios, and Python clients (httpx, requests)Background
Access-Control-Expose-Headersis a CORS response header that tells browsers which headers from the response are accessible to JavaScript. Setting it as a request header does nothing.The fix removes the header from:
typescript/packages/x402-fetch/src/index.tstypescript/packages/x402-axios/src/index.tspython/x402/src/x402/clients/httpx.pypython/x402/src/x402/clients/requests.pyTest plan