fix: prevent GET_ACCOUNTS from redirecting to app

coinhall · Oct 4, 2023 · 3d391cd · 3d391cd
1 parent db3d64e
commit 3d391cd
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## `v0.0.34`
+
+### Fixes
+
+- Prevent redirecting users to the mobile app when querying for the user's account via WalletConnect (on first connect)
+
 ## `v0.0.33`
 
 ### Fixes

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "cosmes",
-  "version": "0.0.33",
+  "version": "0.0.34",
   "private": false,
   "packageManager": "[email protected]",
   "sideEffects": false,

diff --git a/src/wallet/walletconnect/WalletConnectV2.ts b/src/wallet/walletconnect/WalletConnectV2.ts
@@ -243,7 +243,11 @@ export class WalletConnectV2 {
       throw new Error("Session not found for " + chainId);
     }
     const { topic } = JSON.parse(session) as StorageSession;
-    if (isMobile()) {
+    if (
+      isMobile() &&
+      // GET_ACCOUNTS does not require the user to authorise
+      method !== Method.GET_ACCOUNTS
+    ) {
       window.location.href = isAndroid()
         ? this.mobileAppDetails.android
         : this.mobileAppDetails.ios;