Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SignOptions for Keplr using WalletConnect #71

Closed
wants to merge 1 commit into from
Closed

Add SignOptions for Keplr using WalletConnect #71

wants to merge 1 commit into from

Conversation

StrathCole
Copy link
Contributor

No description provided.

@StrathCole
Copy link
Contributor Author

StrathCole commented Jun 14, 2024 •
edited
Loading

fixes #61

@AaronCQL AaronCQL mentioned this pull request Jun 20, 2024
Merged
@StrathCole
Copy link
Contributor Author

Closing in favor of #73

@StrathCole StrathCole closed this Jun 20, 2024
AaronCQL added a commit that referenced this pull request Jun 21, 2024
@AaronCQL
fix: add default sign options to wallet connect sign funcs (#73)
36ef5e0 
This PR adds the `preferNoSetFee` and `preferNoSetMemo` options
hardcoded to `true` to the `WalletConnectV2` class. See #61 for the
relevant issue. If tested to be working, this PR should take precedence
over #71 as this implementation is much simpler.

- Closes #61
- Closes #71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@StrathCole