Skip to content

Conversation

@Wiktor-99
Copy link

I struggle to get these configs working for me, so I think it might be helpful to add such examples.

Copy link

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could see some utility in --mixin verbose to manage the console_direct event handler but I don't think there's any advantage to creating a mixin for the merge-install flag.

{
"build": {
"merge-install": {
"merge-install": "True"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain how you use this?

Without the mixin, an invocation would use

colcon build --merge-instal ...

But with the mixin it would be

colcon build --mixin merge-install

to do the exact same thing so I don't think this mixin makes sense.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you put it this way, it does seem odd. My use case includes other things, like many cmake arguments and so on. I've struggled to add this as an additional option, so I wanted to leave it here as an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants