- 
                Notifications
    You must be signed in to change notification settings 
- Fork 358
Transparent encryption #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| Hi @urykhy, thanks for the huge contribution! I am interested in supporting this feature, but I lack the context to understand if the implementation is correct. If you're willing to put a bit more work in, I think we could get this merged. To start with, I would feel better if we could add some more tests. The tests you added are a good start, but they are far from comprehensively testing this behavior. I wonder if it would make sense to run the entire test suite again (as another job on gh actions) with  | 
29f7c79    to
    07e9b80      
    Compare
  
    ecd3fb3    to
    07b180c      
    Compare
  
    fc86aad    to
    27b129b      
    Compare
  
    1328f22    to
    8e23a17      
    Compare
  
    | 
 test added. | 
2680dfb    to
    982b1e4      
    Compare
  
    00a4963    to
    00d1c5b      
    Compare
  
    | Thanks for sticking with this! | 
| @colinmarc Any plans to merge this pr ? | 
| @colinmarc hello, any chances ? ;) | 
Fixes #280