Refactor retry code on top of tokio-retry2 and macros #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
backoff
crate has been unmaintained for a while now, so this switches totokio-retry2
as gitlab-runner-rs now uses:collabora/gitlab-runner-rs#90
Additionally, mixing async code with non-FnOnce (especially FnMut) closures can be rather perilous, resulting a maze of extra locks and clones. This is bad as-is in the runner, but
tokio-retry2
itself uses an FnMut closure in its API, which makes everything worse. Instead, just switch to a lightweight macro, which also makes it cleaner to pass in a block.