Allow overriding label for values #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djay
requested changes
Sep 22, 2023
src/collective/volto/formsupport/restapi/services/submit_form/field.py
Outdated
Show resolved
Hide resolved
src/collective/volto/formsupport/restapi/services/submit_form/post.py
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 7920161992Details
💛 - Coveralls |
# Conflicts: # src/collective/volto/formsupport/restapi/services/submit_form/post.py
… needs to override this for some reason in the future
# Conflicts: # src/collective/volto/formsupport/restapi/services/submit_form/post.py # src/collective/volto/formsupport/tests/test_send_action_form.py
# Conflicts: # src/collective/volto/formsupport/restapi/services/submit_form/post.py
|
While getting this up-to-date, I noticed we are now removing fields who's IDs don't exist on the form block definition (great!). This logic needs updating to account for custom_field_id being sent rather than the original field ID |
# Conflicts: # src/collective/volto/formsupport/tests/test_send_action_form.py
|
@JeffersonBledsoe Add some tests please |
Ah ok, exists already, just opened old version of this pr in some way :D |
Haha, thanks for checking! 😄 I look forward to the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the concept of a 'display value' to change how a value will appear in an email or on a form. For example, a 'Single choice' field could have submitted values of
['A', 'B', 'C'], but are shown to the user as['Option A', 'Value B', 'Option C'].Mostly tested in production with the 'Yes/ No widget' in volto-form-block, but should work for other fields too!
Requires collective/volto-form-block#85 for frontend