Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datatable #46

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

datatable #46

wants to merge 19 commits into from

Conversation

mamico
Copy link
Contributor

@mamico mamico commented Feb 4, 2024

See: collective/volto-form-block#78

Manage attachment fields

  • Save attachments as blobfile in the storage adapater
  • add a view to download them
  • returns attachments info in the restapi @form-data endpoint

…ew to download them, returns

  attachment info in the restapi @form-data endpoint.
…record of all the forms,

  now if there is a block_id parameter, the csv is filtered on that.
@coveralls
Copy link

coveralls commented Feb 6, 2024

Pull Request Test Coverage Report for Build 7806690117

  • -11 of 100 (89.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+2.4%) to 91.917%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/collective/volto/formsupport/datamanager/catalog.py 12 13 92.31%
src/collective/volto/formsupport/restapi/services/submit_form/post.py 29 30 96.67%
src/collective/volto/formsupport/restapi/services/form_data/csv.py 8 12 66.67%
src/collective/volto/formsupport/browser/saved_data.py 36 41 87.8%
Files with Coverage Reduction New Missed Lines %
src/collective/volto/formsupport/restapi/services/form_data/form_data.py 1 95.24%
Totals Coverage Status
Change from base Build 7462752765: 2.4%
Covered Lines: 705
Relevant Lines: 767

💛 - Coveralls

@mamico mamico marked this pull request as ready for review February 6, 2024 22:13
@mamico mamico marked this pull request as draft June 13, 2024 13:48
@mamico mamico marked this pull request as ready for review June 29, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants