prevent index out of bounds when parsing empty state

colyseus · Feb 29, 2020 · 83d671b · 83d671b
1 parent 1954d98
commit 83d671b
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/Assets/Plugins/Colyseus/Serializer/Schema/Schema.cs b/Assets/Plugins/Colyseus/Serializer/Schema/Schema.cs
@@ -463,14 +463,14 @@ public void Decode(byte[] bytes, Iterator it = null)
       var changes = new List<DataChange>();
       var totalBytes = bytes.Length;
 
-      // skip TYPE_ID of existing instances
-      if (bytes[it.Offset] == (byte) SPEC.TYPE_ID)
-      {
-        it.Offset += 2;
-      }
-
       while (it.Offset < totalBytes)
       {
+        // skip TYPE_ID of existing instances
+        if (bytes[it.Offset] == (byte) SPEC.TYPE_ID)
+        {
+          it.Offset += 2;
+        }
+
         var isNil = decode.NilCheck(bytes, it);
         if (isNil) { it.Offset++; }