fix: prevent counting unchanged refs after encodeAll

colyseus · Aug 19, 2020 · ec3b136 · ec3b136
1 parent b87ba50
commit ec3b136
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/Assets/Plugins/Colyseus/Serializer/Schema/ReferenceTracker.cs b/Assets/Plugins/Colyseus/Serializer/Schema/ReferenceTracker.cs
@@ -13,7 +13,7 @@ public class ReferenceTracker
 
 		public ReferenceTracker() {}
 
-		public void Add(int refId, IRef _ref)
+		public void Add(int refId, IRef _ref, bool incrementCount = true)
 		{
 			int previousCount;
 
@@ -26,7 +26,10 @@ public void Add(int refId, IRef _ref)
 				previousCount = refCounts[refId];
 			}
 
-			refCounts[refId] = previousCount + 1;
+			if (incrementCount)
+			{
+				refCounts[refId] = previousCount + 1;
+			}
 		}
 
 		public IRef Get(int refId)

diff --git a/Assets/Plugins/Colyseus/Serializer/Schema/Schema.cs b/Assets/Plugins/Colyseus/Serializer/Schema/Schema.cs
@@ -365,10 +365,7 @@ public void Decode(byte[] bytes, Iterator it = null, ReferenceTracker refs = nul
 							}
 						}
 
-						if (value != previousValue)
-						{
-							refs.Add(refId, (IRef)value);
-						}
+						refs.Add(refId, (IRef)value, (value != previousValue));
 					}
 				}
 				else if (childType == null)
@@ -420,10 +417,7 @@ public void Decode(byte[] bytes, Iterator it = null, ReferenceTracker refs = nul
 						}
 					}
 
-					if (valueRef != previousValue)
-					{
-						refs.Add(refId, (IRef)value);
-					}
+					refs.Add(refId, (IRef)value, (valueRef != previousValue));
 				}
 
 				bool hasChange = (previousValue != value);