Clarified protected connection call #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix to community report: colyseus/colyseus-unity-sdk#147 ConnectToServer is a protected method and therefore cannot be call outside of ExampleManager (or the user's child class)
|
Closing this PR for right now as, after discussing with Endel, we have decided to make some more modifications to the Connection call that will require further documentation updating |
Made to match new naming and explain the flow and functionality more clearly
Removed the entire "Connecting to Server" section and dispersed the information between "Colyseus Manager" and "Client" sections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to community report: colyseus/colyseus-unity-sdk#147
ConnectToServer is a protected method and therefore cannot be call outside of ExampleManager (or the user's child class)