[OPIK-1093] add clickhouse-backup container #2535
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obezpalko
changed the title
andrescrz
reviewed
Jun 23, 2025
andrescrz
previously approved these changes
Jun 23, 2025
obezpalko
force-pushed
the
OPIK-1093-implement-clickhouse-backup
branch
2 times, most recently
from
d06ad66 to
2e27e91
Compare
andrescrz
previously approved these changes
Jun 23, 2025
obezpalko
force-pushed
the
OPIK-1093-implement-clickhouse-backup
branch
4 times, most recently
from
8c1d001 to
edb837b
Compare
obezpalko
force-pushed
the
OPIK-1093-implement-clickhouse-backup
branch
from
edb837b to
3186188
Compare
liyaka
requested changes
Jul 8, 2025
There was a problem hiding this comment.
let's rename it to clickhouse-monitoring-service.yaml
There was a problem hiding this comment.
there is a serviceMonitor for the operator, why do we need one for clickhouse itself as well?
| BACKUPS_TO_KEEP_REMOTE: 3 | ||
| REMOTE_STORAGE: s3 | ||
| S3_ACL: private | ||
| # S3_ENDPOINT: http://opik-minio:9000 |
There was a problem hiding this comment.
these should be uncommented, so it will work out of the box for open source users which will enable backup.
I also think that backup should be enabled by only one clickhouse.backup.enabled=true with no need for clickhouse.backup.backupServer.enabled=true since this is the only solution we offer for cickhouse backup.
| port: 7171 | ||
| image: altinity/clickhouse-backup:2.6.23 | ||
| backupCronJob: | ||
| enabled: false |
There was a problem hiding this comment.
same here - only one toggle to enable backup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPIK-1093