-
Notifications
You must be signed in to change notification settings - Fork 785
NA: Fix OpenAPI generated Docs #2573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
212cd5e
to
2e51e11
Compare
02b42dc
to
dd0b520
Compare
dd0b520
to
c19e846
Compare
🌿 Preview your docs: https://opik-preview-1d5a601f-9be8-4065-a395-cba451282022.docs.buildwithfern.com/docs/opik No broken links found |
Backend Tests Results4 114 tests 4 111 ✅ 19m 31s ⏱️ Results for commit 24dadae. ♻️ This comment has been updated with latest results. |
🌿 Preview your docs: https://opik-preview-1b9eeae9-1a72-4760-bffe-34e52dd02411.docs.buildwithfern.com/docs/opik No broken links found |
🌿 Preview your docs: https://opik-preview-f581444d-8b92-4792-aeb0-05987fac7658.docs.buildwithfern.com/docs/opik The following broken links where found: Page: Page: Page: Page: Page: Page: Page: Page: Page: Page: Page: Page: Page: Page: Page: Page: Page: Page: Page: |
🌿 Preview your docs: https://opik-preview-a97c4315-9244-4fda-ba67-d88670eeae73.docs.buildwithfern.com/docs/opik No broken links found |
SDK E2E Tests Results0 tests 0 ✅ 0s ⏱️ Results for commit 06623be. ♻️ This comment has been updated with latest results. |
🌿 Preview your docs: https://opik-preview-7195a930-49e3-4e7a-a75f-cda0649b11bf.docs.buildwithfern.com/docs/opik No broken links found |
🌿 Preview your docs: https://opik-preview-56fc9415-b123-4b53-aa38-56d66c1aa3a6.docs.buildwithfern.com/docs/opik No broken links found |
769fe0d
to
24dadae
Compare
🌿 Preview your docs: https://opik-preview-c788205c-7d4d-4901-9e2d-dd44138d1e4f.docs.buildwithfern.com/docs/opik No broken links found |
Details
FeedbackScoreBatchThread
andFeedbackScoreBatch
. In the previous PR, I renamed the model name and accidentally made the id field of it optional. This PR addresses this issue by avoiding the need to rename the class. (Actually, I had to change the class hierarchy so we could use the same name, while still allowing polymorphism) . However, avoid too much code duplication. I had to make both objects extend the same base class.