Skip to content

NA: Fix OpenAPI generated Docs #2573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 30, 2025

Conversation

thiagohora
Copy link
Contributor

@thiagohora thiagohora commented Jun 25, 2025

Details

  • Fix issue with required fields on FeedbackScoreBatchThread and FeedbackScoreBatch. In the previous PR, I renamed the model name and accidentally made the id field of it optional. This PR addresses this issue by avoiding the need to rename the class. (Actually, I had to change the class hierarchy so we could use the same name, while still allowing polymorphism) . However, avoid too much code duplication. I had to make both objects extend the same base class.

@thiagohora thiagohora force-pushed the thiagohora/NA_fix_openapi_generated_docs branch 3 times, most recently from 212cd5e to 2e51e11 Compare June 25, 2025 11:31
@thiagohora thiagohora marked this pull request as ready for review June 25, 2025 11:38
@thiagohora thiagohora requested review from a team as code owners June 25, 2025 11:38
@thiagohora thiagohora force-pushed the thiagohora/NA_fix_openapi_generated_docs branch 2 times, most recently from 02b42dc to dd0b520 Compare June 26, 2025 11:02
@thiagohora thiagohora force-pushed the thiagohora/NA_fix_openapi_generated_docs branch from dd0b520 to c19e846 Compare June 26, 2025 11:07
@thiagohora thiagohora self-assigned this Jun 26, 2025
Copy link
Contributor

🌿 Preview your docs: https://opik-preview-1d5a601f-9be8-4065-a395-cba451282022.docs.buildwithfern.com/docs/opik

No broken links found

@comet-ml comet-ml deleted a comment from github-actions bot Jun 26, 2025
@comet-ml comet-ml deleted a comment from github-actions bot Jun 26, 2025
@comet-ml comet-ml deleted a comment from github-actions bot Jun 26, 2025
@comet-ml comet-ml deleted a comment from github-actions bot Jun 26, 2025
@comet-ml comet-ml deleted a comment from github-actions bot Jun 26, 2025
@comet-ml comet-ml deleted a comment from github-actions bot Jun 26, 2025
@comet-ml comet-ml deleted a comment from github-actions bot Jun 26, 2025
@comet-ml comet-ml deleted a comment from github-actions bot Jun 26, 2025
@comet-ml comet-ml deleted a comment from github-actions bot Jun 26, 2025
@comet-ml comet-ml deleted a comment from github-actions bot Jun 26, 2025
@comet-ml comet-ml deleted a comment from github-actions bot Jun 26, 2025
@comet-ml comet-ml deleted a comment from github-actions bot Jun 26, 2025
Copy link
Contributor

github-actions bot commented Jun 26, 2025

Backend Tests Results

4 114 tests   4 111 ✅  19m 31s ⏱️
  179 suites      3 💤
  179 files        0 ❌

Results for commit 24dadae.

♻️ This comment has been updated with latest results.

Copy link
Contributor

🌿 Preview your docs: https://opik-preview-1b9eeae9-1a72-4760-bffe-34e52dd02411.docs.buildwithfern.com/docs/opik

No broken links found

Copy link
Contributor

🌿 Preview your docs: https://opik-preview-f581444d-8b92-4792-aeb0-05987fac7658.docs.buildwithfern.com/docs/opik

The following broken links where found:

Page:
❌ Broken link: { ()

Page:
❌ Broken link: "config": { ()

Page:
❌ Broken link: "method": "HEAD ()

Page:
❌ Broken link: "url": "https://docs.konghq.com/gateway/latest/ ()

Page:
❌ Broken link: "headers": { ()

Page:
❌ Broken link: "User-Agent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_2) AppleWebKit/537.36 (KHTML ( like Gecko) Chrome/79.0.3945.117 Safari/537.36)

Page:
❌ Broken link: } ()

Page:
❌ Broken link: "responseType": "stream ()

Page:
❌ Broken link: "timeout": null ()

Page:
❌ Broken link: } ()

Page:
❌ Broken link: "error": { ()

Page:
❌ Broken link: "message": "request to https://developer.konghq.com/gateway/ failed ( reason: socket hang up)

Page:
❌ Broken link: "type": "system ()

Page:
❌ Broken link: "errno": "ECONNRESET ()

Page:
❌ Broken link: "code": "ECONNRESET ()

Page:
❌ Broken link: } ()

Page:
❌ Broken link: "code": "ECONNRESET ()

Page:
❌ Broken link: } ()

Page:
❌ Broken link: ] ()

Copy link
Contributor

🌿 Preview your docs: https://opik-preview-a97c4315-9244-4fda-ba67-d88670eeae73.docs.buildwithfern.com/docs/opik

No broken links found

Copy link
Contributor

github-actions bot commented Jun 27, 2025

SDK E2E Tests Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 06623be.

♻️ This comment has been updated with latest results.

Copy link
Contributor

🌿 Preview your docs: https://opik-preview-7195a930-49e3-4e7a-a75f-cda0649b11bf.docs.buildwithfern.com/docs/opik

No broken links found

Copy link
Contributor

🌿 Preview your docs: https://opik-preview-56fc9415-b123-4b53-aa38-56d66c1aa3a6.docs.buildwithfern.com/docs/opik

No broken links found

@thiagohora thiagohora force-pushed the thiagohora/NA_fix_openapi_generated_docs branch from 769fe0d to 24dadae Compare June 27, 2025 09:55
Copy link
Contributor

🌿 Preview your docs: https://opik-preview-c788205c-7d4d-4901-9e2d-dd44138d1e4f.docs.buildwithfern.com/docs/opik

No broken links found

@thiagohora thiagohora merged commit 1c28ce1 into main Jun 30, 2025
61 of 64 checks passed
@thiagohora thiagohora deleted the thiagohora/NA_fix_openapi_generated_docs branch June 30, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants