Skip to content

OPIK-1763: Define project level configuration to auto close threads #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

thiagohora
Copy link
Contributor

@thiagohora thiagohora commented Jun 29, 2025

Details

  • Add Project-level Configuration for auto-close threads
  • Update Auto-close Job

@thiagohora thiagohora force-pushed the thiagohora/OPIK-1763_define_project_level_configuration_to_auto_close_threads branch 2 times, most recently from 6135924 to c510419 Compare June 29, 2025 16:04
Copy link
Contributor

github-actions bot commented Jun 29, 2025

Backend Tests Results

  182 files  +1    182 suites  +1   19m 44s ⏱️ +11s
4 129 tests +6  4 126 ✅ +6  3 💤 ±0  0 ❌ ±0 
4 124 runs  +6  4 121 ✅ +6  3 💤 ±0  0 ❌ ±0 

Results for commit 14f4cf3. ± Comparison against base commit d9bebfd.

This pull request removes 1 and adds 7 tests. Note that renamed tests count towards both.
com.comet.opik.api.resources.v1.jobs.TraceThreadsClosingJobTest$TraceThreadsClosingJob ‑ shouldCloseTraceThreadsForProject(TraceThreadService)
com.comet.opik.api.resources.v1.jobs.TraceThreadsClosingJobTest$TraceThreadsClosingJob ‑ shouldCloseTraceThreadsForProject
com.comet.opik.api.resources.v1.jobs.TraceThreadsClosingJobTest$TraceThreadsClosingJob ‑ shouldCloseTraceThreadsForProjectWithCustomTimeout
com.comet.opik.api.resources.v1.priv.ProjectsResourceTest$UpsertProjectConfigurations ‑ upsertProjectConfigurations__whenDurationLongerThan7Days__thenReturnBadRequest
com.comet.opik.api.resources.v1.priv.ProjectsResourceTest$UpsertProjectConfigurations ‑ upsertProjectConfigurations__whenInvalidDuration__thenReturnBadRequest
com.comet.opik.api.resources.v1.priv.ProjectsResourceTest$UpsertProjectConfigurations ‑ upsertProjectConfigurations__whenNonExistentProject__thenReturnNotFound
com.comet.opik.api.resources.v1.priv.ProjectsResourceTest$UpsertProjectConfigurations ‑ upsertProjectConfigurations__whenNullTimeout__thenReturnSuccess
com.comet.opik.api.resources.v1.priv.ProjectsResourceTest$UpsertProjectConfigurations ‑ upsertProjectConfigurations__whenValidData__thenReturnSuccess

♻️ This comment has been updated with latest results.

@thiagohora thiagohora force-pushed the thiagohora/OPIK-1763_define_project_level_configuration_to_auto_close_threads branch from c510419 to 91a6abb Compare June 30, 2025 08:12
@thiagohora thiagohora marked this pull request as ready for review June 30, 2025 10:42
@thiagohora thiagohora requested a review from a team as a code owner June 30, 2025 10:42
@thiagohora thiagohora merged commit 99ce5fb into main Jul 1, 2025
12 checks passed
@thiagohora thiagohora deleted the thiagohora/OPIK-1763_define_project_level_configuration_to_auto_close_threads branch July 1, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants