Fixes #15, #17, #18, and does other improvements #16
Conversation
…arator The tests currently trigger a crash, as described in comigor#15
This fixes the failing tests.
This fixes the failing tests.
Previously, single-weighted searches returned score = 0, due to the single weight zeroing them out. Also, comparing the results of searching with a single key vs non-weighted search on the same strings gave different outputs, which was very counter-intuitive.
|
Thanks @luistrivelatto. I'll use your fork and report back. |
|
Hello @luistrivelatto, thank you so much for this PR (and sorry for the late reply)! |
* origin/master: Fix linter OMG Bump dependencies, fix CI
luistrivelatto
changed the title
|
Thanks @comigor. Sorry about piling up commits in a single PR, I've changed the title to reflect the changes better. I'm currently using the lib for tokenized, weighted search, and the results are satisfying. I've gathered 50+ search tests on my data, and only one of them didn't give the expected intuitive results, but I don't consider it a fault of the algorithm because it's due to some use case-specific "gotcha" (a search token ends up being substring of two item tokens, then gives 2 perfect matches when I expected one). I can live with that hehe Thanks for the package :) |
|
@luistrivelatto No problems! Thanks for stepping up and fix those issues! Before we merge, could you please update the CHANGELOG with all the changes you did? |
|
Sure, done. |
|
Thank you very much! |
|
Published as 0.3.0 |
Added tests reproducing the crash in #15, and fixed by removing empty tokens after tokenizing.