Skip to content

Conversation

@incognitojam
Copy link
Collaborator

@incognitojam incognitojam commented Jun 1, 2024

I'm not sure what I had in mind when I created the app, but we don't need 95% of the features Next.js provides.

  • remove Next.js
  • use vite to build
  • import fonts using fontsource (instead of next/font)
  • setup eslint (previously using next config)
  • replace next-plausible with script import in index.html (and removed event tracking in fastboot.js)

This might be an easier first step than switching to a different framework - the react stuff still works!

@adeebshihadeh
Copy link
Collaborator

So moving off React here is mostly a testing ground for connect, but I agree this is a good start!

@wgenh
Copy link

wgenh commented Jun 1, 2024

Should PR #43 be closed?

@adeebshihadeh adeebshihadeh merged commit 0a66ca6 into commaai:master Jun 1, 2024
@incognitojam incognitojam deleted the vite-react branch June 1, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants