feat: Device sharing

[paytontech]

adds device sharing & un-sharing device as well as a list of users the device is shared with. here's a demo video:

Screen.Recording.2025-05-06.at.3.59.53.PM.mov

open to feedback, would like to know what to change/fix etc. thanks!

[github-actions]

Changes:

path	lines	diff
./pages/dashboard/activities/SettingsActivity.tsx	452	+47
./api/devices.ts	131	+18

Total lines: 4795 (+65)

[github-actions]

deployed preview: https://601.connect-d5y.pages.dev

Welcome to connect! Make sure to:

• read the contributing guidelines
• mark your PR as a draft until it's ready to review
• post the preview on Discord; feedback from users will speedup the PR review

Mobile

Desktop

[incognitojam]

Thanks for the PR, let's just fix these things

[paytontech]

thanks for the feedback! I didn't even notice those APIs were already available, thanks for catching that! I tried using onInput already, but it didn't seem to work. I'll try again, maybe I did something wrong. Agree on the design, it definitely needs some improvement. will work on that, appreciate it

[incognitojam]

Those methods are in the other comma-api package, but we aren't using that directly because it's written in JS and doesn't have TypeScript type hints

[paytontech]

Took your design advice, is this any better

?

[incognitojam]

It looks better, but I think it needs a little more work

The device settings didn't look nice in the first place, but you can see in this PR (since reverted, will be added again eventually) where I added the device name field and made the text field take up all of the space, with the update button at the end.

commaai/connect#576
https://590.connect-d5y.pages.dev/c1bd6d7f12f35286/settings

[incognitojam]

Make the text field fill the entire space instead of leaving a gap between it and the share button

[paytontech]

got it, thank you!

[incognitojam]

Oh I think I see the problem you had with adding your own listener - let me have a look at what I did last time

[incognitojam]

This link should show you how I used the TextField element in the "update device name" PR. Instead of using event listeners to update a signal with the email, you can use a <form> and an action: https://github.com/commaai/connect/pull/576/files#diff-a7d1050a0f5b1fa110b856ccc635b4621bdc0badb012da94d93c3fabc2d63e98R403-R416

Then you can useSubmission to get things like .pending.

[paytontech]

that's really helpful, I appreciate it! working on doing this now