Skip to content

fix: gracefully handle routes missing start/end times #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
greatgitsby wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: gracefully handle routes missing start/end times #607

greatgitsby wants to merge 3 commits into from

Conversation

@greatgitsby
Copy link
Contributor

@greatgitsby greatgitsby commented Aug 31, 2025 •
edited
Loading

resolves: #60

  • card color is black if no start/end
  • group routes missing start/end time with nearest date. they will be ordered by create date so it's as accurate as we can get given the data without making the UX clunkier (don't want to group them separately)
  • use dateStr in route activity title if date is missing
image

@github-actions
Copy link

github-actions bot commented Aug 31, 2025 •
edited
Loading

Changes:

path lines diff
./pages/dashboard/components/RouteList.tsx 161 +7

Total lines: 4751 (+7)

@github-actions
Copy link

github-actions bot commented Aug 31, 2025 •
edited
Loading

deployed preview: https://607.connect-d5y.pages.dev

Welcome to connect! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

Mobile

Desktop

@greatgitsby greatgitsby force-pushed the fix/hide-routes-missing-time branch from 5d6dc56 to a6e7051 Compare August 31, 2025 00:56
@greatgitsby greatgitsby changed the title fix: hide routes missing start/end times fix: gracefully handle routes missing start/end times Aug 31, 2025
@greatgitsby greatgitsby marked this pull request as ready for review August 31, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle routes with no time

1 participant

@greatgitsby