-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: bundle size limit #62
Conversation
deployed preview: https://62.connect-d5y.pages.devWelcome to new-connect! Make sure to:
MobileDesktop |
I like how simple this is, but might be worth using something like this https://www.npmjs.com/package/vite-bundle-visualizer I ran that, and it made it super clear that HLS is most of the size. List of top 10 things with their size and percent of the total might be enough, though. |
After reviewing the recent new PRs (particularly #68), I realized you were right with the first approach. Simple, readable bash script beats several-word-npm-dependency every time. Let's be very careful with our dependencies. Want to make a PR to revert back to that and maybe make it a bit easier to see that HLS.js was the biggest thing? |
|
Checks if the gzip size from
vite-bundle-visualizer
is under 500K. Also uploads the html to the build artifacts.https://github.com/signed-long/new-connect/actions/runs/9900858794
Resolves #57