Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: bundle size limit #62

Merged
merged 9 commits into from
Jul 12, 2024
Merged

Conversation

signed-long
Copy link
Contributor

@signed-long signed-long commented Jul 11, 2024

Checks if the gzip size from vite-bundle-visualizer is under 500K. Also uploads the html to the build artifacts.

https://github.com/signed-long/new-connect/actions/runs/9900858794

Resolves #57

Copy link

github-actions bot commented Jul 11, 2024

deployed preview: https://62.connect-d5y.pages.dev

Welcome to new-connect! Make sure to:

  • read the contributing guidelines
  • mark your PR as a draft until it's ready to review
  • post the preview on Discord; feedback from users will speedup the PR review

Mobile

Desktop

@adeebshihadeh
Copy link
Contributor

I like how simple this is, but might be worth using something like this https://www.npmjs.com/package/vite-bundle-visualizer

I ran that, and it made it super clear that HLS is most of the size. List of top 10 things with their size and percent of the total might be enough, though.

@adeebshihadeh adeebshihadeh merged commit c4e2ec5 into commaai:master Jul 12, 2024
2 checks passed
@adeebshihadeh
Copy link
Contributor

After reviewing the recent new PRs (particularly #68), I realized you were right with the first approach. Simple, readable bash script beats several-word-npm-dependency every time. Let's be very careful with our dependencies.

Want to make a PR to revert back to that and maybe make it a bit easier to see that HLS.js was the biggest thing?

@signed-long
Copy link
Contributor Author

signed-long commented Jul 13, 2024

After reviewing the recent new PRs (particularly #68), I realized you were right with the first approach. Simple, readable bash script beats several-word-npm-dependency every time. Let's be very careful with our dependencies.

Want to make a PR to revert back to that and maybe make it a bit easier to see that HLS.js was the biggest thing?

#72

vishalkrishnads pushed a commit to vishalkrishnads/new-connect that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement bundle size limit in CI
2 participants