Remove STEER_MAX limit for Genesis G90 #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G90 does not require steer limiter
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:
- Convert your PR to a draft unless it's ready to review
- Read the contributing docs
- Before marking as "ready for review", ensure:
- the goal is clearly stated in the description
- all the tests are passing
- include a route or your device' dongle ID if relevant
|
Including debug of car commanding and holding steer value of 384 without backing off in a tight freeway exit turn |
erikfleischer
pushed a commit
to erikfleischer/opendbc
that referenced
this pull request
Jan 19, 2025
Update values.py G90 does not require steer limiter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2018 Genesis G90 should not be subject to the 255 steer max limit as it is fully capable of requesting the default 384 without error. I have been driving with this change since February with over 7k miles without issue. Attaching most recent route.
Car
2018 Genesis G90
Route
590a1a98ea35681c/2024-12-20--16-07-15/0
Including debug of car commanding and holding steer value of 384 without backing off in a tight freeway exit turn
