Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyundai: Use CanBus for bus assignments #1853

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Hyundai: Use CanBus for bus assignments #1853

wants to merge 12 commits into from

Conversation

sunnyhaibin
Copy link
Contributor

Description

  • Refactored CAN bus naming to use standardized terms: MAIN, ALT, and CAMERA.
  • Enhanced code readability and maintainability with the updated CanBus abstraction.
  • Adjusted message creation, parsing, and fingerprint logic to align with the new bus definitions.
  • Apply to both CAN and CAN FD platforms

@github-actions github-actions bot added car related to opendbc/car/ hyundai labels Feb 26, 2025
@sunnyhaibin sunnyhaibin changed the title Hyundai: Global bus assignments Hyundai: Use CanBus for bus assignments Feb 26, 2025
@sunnyhaibin sunnyhaibin marked this pull request as ready for review February 26, 2025 05:22
@sunnyhaibin sunnyhaibin mentioned this pull request Feb 26, 2025
Open
6 tasks
@sunnyhaibin
Copy link
Contributor Author

Validation: https://github.com/commaai/openpilot/actions/runs/13537185484/job/37830880761?pr=34714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
car related to opendbc/car/ hyundai
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sunnyhaibin